Clean up Following edit view

[jcarbaugh]

The edit view of the Following list needs some adjustments. We should either:

• remove the left border that gets shifter over
• make the entire select circle area the same color as the left border

[cweber]

Can you even make that whole area the same color given the weird table border that cuts off part way over?

Either option seems reasonable. The color is mostly there as an additional way to call out items that are being followed in a list of things that are/are not being followed. That's not really necessary in a follow view. Though it might lend a little visual continuity to choose option 2.

Hindsight /20/20/etc: The red border might better be reserved for indicating R vs D a la your idea of creating simple inline visualizations of votes on bills (i think that's what that was.)

Caitlin Weber Creative Director | Sunlight Foundation http://www.sunlightfoundation.com/ @CaitlinWeber http://twitter.com/caitlinweber [image: Sunlight Foundation] http://sunlightfoundation.com/ [image: Sunlight Foundation on Twitter] http://twitter.com/sunfoundation[image: Sunlight Foundation on YouTube] http://www.youtube.com/sunlightfoundation

On Wed, Feb 5, 2014 at 5:28 PM, Jeremy Carbaugh notifications@github.comwrote:

The edit view of the Following list needs some adjustments. We should either:

• remove the left border that gets shifter over
• make the entire select circle area the same color as the left border

[image: screen shot 2014-02-05 at 5 26 23 pm]https://f.cloud.github.com/assets/39159/2093149/c87d8fb6-8eb4-11e3-8cfa-b4dd4cab624e.png

Reply to this email directly or view it on GitHubhttps://github.com/sunlightlabs/congress-ios/issues/383 .

[jcarbaugh]

I'd definitely want to leave the border there when in edit mode, I'm just thinking it'll disappear when you've clicked 'Edit' and those circles slide in.

[dcloud]

@jcarbaugh I am confused. You want the border there in edit mode, but you want it to disappear when you click 'Edit'... which puts you in edit mode? :confused:

[jcarbaugh]

Yeah, sorry. I wasn't clear about edit mode. This is kind of what I was thinking:

[cweber]

Or.

[image: Inline image 1]

Caitlin Weber Creative Director | Sunlight Foundation http://www.sunlightfoundation.com/ @CaitlinWeber http://twitter.com/caitlinweber [image: Sunlight Foundation] http://sunlightfoundation.com/ [image: Sunlight Foundation on Twitter] http://twitter.com/sunfoundation[image: Sunlight Foundation on YouTube] http://www.youtube.com/sunlightfoundation

On Tue, Feb 18, 2014 at 10:41 AM, Jeremy Carbaugh notifications@github.comwrote:

Yeah, sorry. I wasn't clear about edit mode. This is kind of what I was thinking:

[image: followingedit]https://f.cloud.github.com/assets/39159/2196708/28c47486-98b3-11e3-93e2-71033558854a.png

Reply to this email directly or view it on GitHubhttps://github.com/sunlightlabs/congress-ios/issues/383#issuecomment-35396535 .

[jcarbaugh]

"[image: Inline image 1]" is exactly what I was thinking.

[cweber]

So I can't add images by email?

Caitlin Weber Creative Director | Sunlight Foundation http://www.sunlightfoundation.com/ @CaitlinWeber http://twitter.com/caitlinweber [image: Sunlight Foundation] http://sunlightfoundation.com/ [image: Sunlight Foundation on Twitter] http://twitter.com/sunfoundation[image: Sunlight Foundation on YouTube] http://www.youtube.com/sunlightfoundation

On Tue, Feb 18, 2014 at 10:51 AM, Jeremy Carbaugh notifications@github.comwrote:

"[image: Inline image 1]" is exactly what I was thinking.

Reply to this email directly or view it on GitHubhttps://github.com/sunlightlabs/congress-ios/issues/383#issuecomment-35397612 .

[cweber]

[jcarbaugh]

:+1: I could go for that too.

[dcloud]

I don't know... that really obscures the checkbox by putting it in a low-contrast situation. That could be addressed, I guess, but the other thing is that it starts to look like the single-tap delete/archive buttons you get in other apps, but it is a select action. We should probably see what the limits are on easily customizing the built-in checkbox button and adjust from there.

[dcloud]

Soooo... customizing that button isn't easy. Seems like we'd need to look for a UITableViewCellEditControl by running through subviews of subviews.

Alternatively, subclass SFTableCell and set contentView.backgroundColor and backgroundView.backgroundColor AND multipleSelectionBackgroundView.backgroundColor? Hurm. :unamused: