search

sunlightlabs / norrin

Conveying messages with the force of the Power Cosmic
GNU General Public License v3.0
3 stars 3 forks source link

Disambiguate between chambers when notifying on upcoming bills #11

Closed dcloud closed 10 years ago

dcloud commented 10 years ago

UpcomingBillService says '%s is scheduled for a vote today' or '%s is scheduled for a vote this week' and @konklone makes the point that which chamber is taking the vote is important. So we should make the chamber a part of the uniqueness check so that if the house and the senate both schedule a vote on the same bill, we notify ppl of both upcoming votes.

konklone commented 10 years ago

And FWIW, this is done in Scout, too. (The bill_id is missing from the ID there because we only deliver updates on scheduling for already-subscribed specific bills.)

jcarbaugh commented 10 years ago

Reopening because I just read the issue fully. Combining notifications. Got it.