sunlightlabs / opencongress

An open website for opening Congress.
http://www.opencongress.org
GNU General Public License v3.0
48 stars 16 forks source link

Some committees missing membership data #289

Closed nickom closed 11 years ago

nickom commented 11 years ago

Seen on:

http://www.opencongress.org/committee/show/6252_senate_committee_on_banking_housing_and_urban_affairs_insurance

http://www.opencongress.org/committee/show/6250_senate_committee_on_banking_housing_and_urban_affairs_housing_and_urban_affairs

http://www.opencongress.org/committee/show/6254_senate_committee_on_banking_housing_and_urban_affairs_hud_oversight_and_structure

http://www.opencongress.org/committee/show/6249_senate_committee_on_banking_housing_and_urban_affairs_financial_institutions

http://www.opencongress.org/committee/show/6248_senate_committee_on_banking_housing_and_urban_affairs_consumer_affairs

http://www.opencongress.org/committee/show/201_house_committee_on_agriculture_nutrition_and_horticulture

http://www.opencongress.org/committee/show/231_house_committee_on_financial_services_domestic_monetary_policy_and_technology

http://www.opencongress.org/committee/show/326_house_committee_on_foreign_affairs_oversight_and_investigations

http://www.opencongress.org/committee/show/6352_house_committee_on_house_administration_oversight

http://www.opencongress.org/committee/show/552_house_committee_on_house_administration_elections

http://www.opencongress.org/committee/show/6351_house_committee_on_oversight_and_government_reform_tarp_financial_services_and_bailouts_of_public_and_private_programs

http://www.opencongress.org/committee/show/929_house_committee_on_oversight_and_government_reform_technology_information_policy_intergovernmental_relations_and_procurement_reform

http://www.opencongress.org/committee/show/199_house_committee_on_science_space_and_technology_technology

http://www.opencongress.org/committee/show/198_house_committee_on_science_space_and_technology_research

http://www.opencongress.org/committee/show/656_house_committee_on_the_judiciary_intellectual_property_competition_and_the_internet

dvogel commented 11 years ago

This is due to our upstream data. The source data is organized by the committee's thomas ID while the IDs exposed on the site are internal DB IDs. Here's a mapping for these:

{
    6248 => "SSBK07",
    6249 => "SSBK03",
    6250 => "SSBK02",
    6252 => "SSBK11",
    6254 => "SSBK10",
    6351 => "HSGO29",
    6352 => "HSHA06",
     199 => "HSSY19",
     198 => "HSSY14",
     929 => "HSGO30",
     201 => "HSAG03",
     656 => "HSJU12",
     552 => "HSHA08",
     326 => "HSFA17",
     231 => "HSBA19"
}

There's probably a good reason the upstream data is missing this membership information but I'll look into it.

konklone commented 11 years ago

I've been getting this warning for a while from my Congress API importer for unitedstates/congress-legislators' committee information:

$ rake task:committees
[HSBA19] MISSING MEMBERSHIP, DESTROYING!
[HSAG03] MISSING MEMBERSHIP, DESTROYING!
[HSFA17] MISSING MEMBERSHIP, DESTROYING!
[HSGO30] MISSING MEMBERSHIP, DESTROYING!
[HSHA08] MISSING MEMBERSHIP, DESTROYING!
[HSGO29] MISSING MEMBERSHIP, DESTROYING!
[HSHA06] MISSING MEMBERSHIP, DESTROYING!
[HSJU12] MISSING MEMBERSHIP, DESTROYING!
[HSSY14] MISSING MEMBERSHIP, DESTROYING!
[HSSY19] MISSING MEMBERSHIP, DESTROYING!

[WARNING] Committees
    Missing members for 10 current committees

This doesn't match up completely with what you're seeing, though. I'd appreciate the research.

dvogel commented 11 years ago

@nickom where did you find these links? They aren't on the committee listing page because they aren't current committees.

nickom commented 11 years ago

I just clicked on every committee listed on the /committee page...

On Thu, Oct 31, 2013 at 11:41 AM, dvogel notifications@github.com wrote:

@nickom https://github.com/nickom where did you find these links? They aren't on the committee listing page because they aren't current committees.

— Reply to this email directly or view it on GitHubhttps://github.com/sunlightlabs/opencongress/issues/289#issuecomment-27496806 .

konklone commented 11 years ago

Just went and checked in on all of my examples above, which were all subcommittees that don't exist anymore. This might clear up some of your situation.

dvogel commented 11 years ago

I can't reproduce this on the production site. You must have checked it just before we ran the committee importer. Re-open this if you see it come up again.

nickom commented 11 years ago

Looks like it's fixed, thanks Drew!