search

sunlightlabs / opencongress

An open website for opening Congress.
http://www.opencongress.org
GNU General Public License v3.0
48 stars 16 forks source link

Strong params #469

Closed plantfansam closed 9 years ago

plantfansam commented 9 years ago

This branch implements strong parameters and rips attr_accessible from our code.

It also gets Cucumber tests up and running. There are some intermittent issues with VCR and an inconvenient command line syntax, but I'm going to fix those. You can run Cucumber specs by running:

RAILS_ROOT=/rails/root/directory bundle exec cucumber spec/features/feature_file.feature

To get Cucumber to work, I had to move from a transactional database cleaning strategy to a :truncate one. This slows down rspec tests; I'm also going to figure out how to fix this.

Cspeisman commented 9 years ago

Hey @handlers, two test failed but @crdunwel assures me that its just his legos being all over the floor. I'm going to merge this.

plantfansam commented 9 years ago

Yeah -- I should have run the rspec specs before submitting the PR. Issue must have cropped up when rebasing. Running tests will be part of my workflow from here on out.