This PR eliminates fixtures from our test suite and consolidates test functionality to the spec directory. We might reintroduce fixtures more deliberately in the future, but we should default to using factories in tests now (creating NthCongresses before the suite runs, perhaps).
In terms of app functionality, I made three changes:
in app/services/location_changed_service.rb, we are now requiring_dependency multi_geocoder. This should be looked at in light of this commit
This PR eliminates fixtures from our test suite and consolidates test functionality to the
specdirectory. We might reintroduce fixtures more deliberately in the future, but we should default to using factories in tests now (creatingNthCongresses before the suite runs, perhaps).In terms of app functionality, I made three changes:
app/services/location_changed_service.rb, we are nowrequiring_dependency multi_geocoder. This should be looked at in light of this commitlib/authenticated_system.rb, we are now using request.url instead of request.request_uri (https://github.com/sunlightlabs/opencongress/commit/a96369dc4efab5ede3c03ce6202391f0bdb363ee) This PR does not address Cucumber tests.Gemfilewe are now specifying our version ofpsych, which was having problems serializing data (a504b7f8e5832db6aba0a087147cd39624dfa275).