search

sunlubo / SwiftFFmpeg

A Swift wrapper for the FFmpeg API
Apache License 2.0
521 stars 83 forks source link

add `seekFile` to AVFormatContext and Expose AVFormatContext inner c AVFormatContext pointer in a convenient way #34

Closed AlaaAlHallaq closed 4 years ago

AlaaAlHallaq commented 4 years ago

ignore .DS_Store and .swiftpm

AlaaAlHallaq commented 4 years ago

this internal extension wont cost any heap allocation, just a convenient way without confusing the users of this library of what the wrapper classes do, and how to access internal pointers.

if this pr merged I will create another one exposing all of the internal pointers the same way.

sunlubo commented 4 years ago

Thanks for your PR, but I think we should wrap the internal API as much as possible instead of exposing the underlying interface.

AlaaAlHallaq commented 4 years ago

@sunlubo I would agree with that, but your library contains 2 modules, and until the wrapper module (SwiftFFMPEG) covers all the underlying interface, a work around should be possible, for example using avformat_seek_file on the current AVFormatContext using CFFmpeg module