Fix fallback args order

sunng87 / diehard

Clojure resilience library for flexible retry, circuit breaker and rate limiter

Eclipse Public License 2.0

330 stars 27 forks source link

Fix fallback args order #25

Closed alinposho closed 4 years ago

alinposho commented 4 years ago

The documented order of the fallback function's arguments is [result exception]. The problem is that the actual way the arguments are passed in is reversed, i.e. [exception result].

alinposho commented 4 years ago

@sunng87 If you have a few minutes to spare, please have a look over this PR: I don't understand why I cannot add you as a reviewer. Also, the Travis failures appear to be related to the Travis configuration:

The command "eval lein deps " failed. Retrying, 3 of 3.

sunng87 commented 4 years ago

Sorry for late. I just cloned your branch and tested locally. The patch looks good to me. I will create a release later today.

alinposho commented 4 years ago

@sunng87 No worries. Glad I could help.

sunng87 commented 4 years ago

Released in 0.8.5