search

sunng87 / diehard

Clojure resilience library for flexible retry, circuit breaker and rate limiter
Eclipse Public License 2.0
330 stars 27 forks source link

upgrade to 0.9.3 produces Execution error, 'Unable to resolve spec: ...' #37

Closed pupcus closed 4 years ago

pupcus commented 4 years ago

For the 0.9.x series, things seem fine through the 0.9.2 release. When I try to use the 0.9.3 release I get the following error when compiling:

Execution error at diehard.util/verify-opt-map-keys-with-spec (util.clj:13).
Unable to resolve spec: :retry/retry-policy-new

We are backing up to 0.9.2 for the work we are doing but I thought you would want to know. Perhaps we are doing something wrong on our end, but this is code that has been working well and has not changed in quite some time.

Thanks for your work on this library! :-)

sunng87 commented 4 years ago

Thank you for the information! Unfortunately I cannot reproduce this issue with my tests. Do you have a context of this error? Is it inside your repl?

msassak commented 4 years ago

I'm seeing the same thing after upgrading to 0.9.3:

Execution error at diehard.util/verify-opt-map-keys-with-spec (util.clj:13).
Unable to resolve spec: :retry/retry-block

I think there is a missing require in diehard.core. To get around the error in 0.9.3 I required diehard.spec before diehard.core and the error is gone.

sunng87 commented 4 years ago

Thank yoy! It's an issue introduced in this lint fix: https://github.com/sunng87/diehard/commit/79e966cd71cfa015533bdf51cdceb41f31b71860

I will fix and create a new release soon.

sunng87 commented 4 years ago

Fixed in 0.9.4

pupcus commented 4 years ago

Thanks! :-)