Open daaku opened 1 year ago
This should be caused by breaking changes introduced in failsafe 3.3, which replaces some Duration
API with Instant
. Can you show me some code so we can see which variable has the type change in this case (it's likely to be *start-time-ms*
)
This is the relevant code:
(defn- deploy-and-email [release {:keys [retry-delay-ms send-email port-current]
:as opts}]
(try
(with-retry
{:retry-on IllegalArgumentException
:delay-ms retry-delay-ms
:max-retries 3
:on-retry
(fn [_result ex]
(m/inc m-deploy-retry)
(when-not (str/includes? (str ex) "Host URL cannot be nil")
(send-email (str "Retry Deploy " release)
[:pre (with-out-str (print-stack-trace ex))])))}
(deploy-release release opts))
(m/inc m-deploy-success)
(send-email (str "Deployed " release) (release-email release opts))
(stop-target port-current opts)
(catch Throwable t
(m/inc m-deploy-fail)
(send-email (str "Failed Deploy " release)
[:pre (with-out-str (print-stack-trace t))]))))
This is weird. It should be *start-time-ms*
that being cast to Duration
. Have you tried a lein clean
for this case?
I was trying to upgrade from
0.11.3
to0.11.6
and one of my tests failed with this. Still investigating but possibly related to e82bf79560f1365f50a38f5e8f40714a3f6be53b?