search

sunng87 / handlebars-iron

Handlebars middleware for Iron web framework
MIT License
119 stars 20 forks source link

Source API #19

Closed sunng87 closed 8 years ago

sunng87 commented 8 years ago

Fixes #18

Adding support for different type of template sources. The current default source is moved to DirectorySource.

sunng87 commented 8 years ago

@untitaker Thanks for review.

The new and from are kept all for backward compatibilities. I would like to switch to new2 and of(maybe a better name for now is from2) eventually.

untitaker commented 8 years ago

I see, so you're planning to merge this PR in a patch version?

Note that 0.1 => 0.2 is allowed to break compat in semver, because the version is below 1.0.

untitaker commented 8 years ago

@sunng87 any update on this?

untitaker commented 8 years ago

Also FWIW I'm using this in a real app already and it works fine (except for the awkward situation re new vs new2, from vs from2)

sunng87 commented 8 years ago

Thanks @untitaker , I will merge this after cleaning up some warnings.

Although we are able to break some API during 0.x versions, I'm going to keep current API for some time and to see if we have better design for new2 and from2.