search

sunng87 / handlebars-rust

Rust templating with Handlebars
MIT License
1.29k stars 139 forks source link

apply clippy fixes #659

Closed cmrschwarz closed 3 months ago

cmrschwarz commented 3 months ago

This fixes all 86 warnings that clippy currently generates on this project. Most of these are in test code and don't really matter. I still believe this is worth it because it makes the use of clippy viable when working on this project. Currently you are quite likely to miss any issues you introduce because there's already so many warnings.

If you disagree, feel free to close this.

This was partially autogenerated using cargo clippy --fix, but manually reviewed & cleaned up. Should hopfully be very easy to review, as nothing really happens.

coveralls commented 3 months ago

Coverage Status

coverage: 81.386% (-0.07%) from 81.457% when pulling 3ebf3d6499c60a49505e98c48e81ac74a035ff01 on cmrschwarz:clippy_fixes into 95a53a833174f5ef2980aca206eae1bf43c2f16e on sunng87:master.

sunng87 commented 3 months ago

Thank you! Because our tests are not covered by github check. Could you please also add cargo clippy --all-targets in the github workflow file to ensure we have tests covered?