search

sunnycupertino / cordova-plugin-admob-simple

Cordova plugin allowing Admob interstitials and banner ads.
MIT License
164 stars 150 forks source link

LARGE_BANNER request #10

Closed oangelo closed 7 years ago

oangelo commented 7 years ago

Could you implement LARGE_BANNER? Thanks

sunnycupertino commented 7 years ago

Thank you for the good suggestion, we have implemented it now. You can activate it by setting LARGE_BANNER in the javascript.

oangelo commented 7 years ago

I tested, and I can't get it to work just by changing AdSize in the javascript. I changed adSize: window.plugins.AdMob.AD_SIZE.SMART_BANNER to adSize: window.plugins.AdMob.AD_SIZE.LARGE_BANNER, but I got a Smart Banner anyway. However, it worked when I changed "private AdSize adSize = AdSize.SMART_BANNER;" to "private AdSize adSize = AdSize.LARGE_BANNER;" in /src/android/AdMob.java. But I don't understand why...

sunnycupertino commented 7 years ago

Good man! You found a bug. Will fix now and update.

sunnycupertino commented 7 years ago

Ok it's fixed now. You can specify LARGE_BANNER from the javascript and it works. Please check the new version.