sunnydl / GamePerformanceTracker

Team project for CSE 115A in Fall 2021, UCSC
3 stars 0 forks source link

Search page implementation #110

Closed Jventoo closed 2 years ago

Jventoo commented 2 years ago

Implements a search bar that users are directed to when trying to access content without a selected player. Helps alleviate some use cases created by not having user auth.

Hao-bot-5000 commented 2 years ago

A proposal I have for this problem:

Rather than the Search page having its own route /search, we can pass the page as a component to the /overview & /match-history route if the summoner is not found. This may fix the issue with the logic since it gets rid of the second step in our logic and would simply render the component after the data has finished fetching and noticed that the summoner has not been found.