search

sunnydroid / Simple-Twitter-Client

Simple Twitter client with Asynch calls to twitter API
0 stars 0 forks source link

Project Submission #2

Open sunnydroid opened 10 years ago

sunnydroid commented 10 years ago

Hey Nathan, please review the updated Twitter app.

I had a few problems with the FragmentTabListener. It seems to be calling the onCreate method of my fragments multiple times, hence the mentions timeline having the same tweet multiple times.

I decided to implemented the profile view as fragments. I am passing the userId to the profile fragment and the user profile timeline fragments so that I can reuse the components for the other story. However I cannot get the timeline view to show. It is the same code as the other two timelines. I see the ajax call returning but the listview does not get populated. I am guessing I have a problem with my layout. If you get a chance, could you please take a look at ProfileActivity.java and /res/layout/activity_profile.xml, and see if you notice anything that seems off.

Thank you.

-Sunny

/cc @nesquena @thecodepath

nesquena commented 10 years ago

Twitter is actually having issues with their API right now https://dev.twitter.com/status and the user timeline is broken which could be causing this issue. I will overlook that issue because of that bad timing. Also, FragmentTabListener shouldn't be causing duplicates, so I hope you can fix this soon. Other than that, looks like you mostly got it working.

:+1: Project looks good. I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.