search

sunnygoyal / scienfic-calculator

A firefox addon to display a calculator in the toolbar. Supports defining custom functions, constant s and operator.
MIT License
1 stars 3 forks source link

Mark the base number on icon #7

Closed yfdyh000 closed 8 years ago

yfdyh000 commented 8 years ago

Users may forget the base has been modified, and get a strange results. For a custom base, it can be marked as C.

Ede123 commented 8 years ago

Good idea! Happened to myself, too, at various occasions.

Ede123 commented 8 years ago

Fixed in abf2cc2b8184281a9d595dc66bf7e8f6c4703169.

You can download a development snapshot here. (you probably have to right click -> save as)

Should this be optional (i.e. should I add a preference for it in options)? I already hide the base for base 10, so most people won't see it almost all the time anyway... Other suggestions are of course welcome, too.

yfdyh000 commented 8 years ago

There are some gaps with my expected, but not bad.

I prefer like this: uBlock badge https://developer.mozilla.org/en-US/Add-ons/SDK/Low-Level_APIs/ui_button_action#Badged_buttons

Ede123 commented 8 years ago

I'll think about it, but I actually like it the way it looks now.

Your suggested design would need a considerable amount of additional code (that might break on updates) and I don't see any real benefit (the additional horizontal space is negligible in my opinion).

Please note that I cannot use the "badged button" you linked to, since Scientific Calculator does not make use of the add-on SDK.

yfdyh000 commented 8 years ago

En, I understand, just an idea, whether it will better if not take up space on the corner. or, a background or border.