sunnyhub / thrift-protobuf-compare

Automatically exported from code.google.com/p/thrift-protobuf-compare
0 stars 0 forks source link

Different data is serialized for different serializers #3

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
There are variances amongst the data that is serialized by the different
serializers.

In ThriftSerializer::create(), this line appears:
Image image2 = new Image("http://javaone.com/keynote_thumbnail.jpg",
"Javaone Keynote", -1, -1, Size.SMALL);

None of the other create() methods have the two "-1" values.

Also, in StdMediaSerializer::create(), these lines appear:
Image image1 = new Image(0, "Javaone Keynote", "A", 0, Image.Size.LARGE)
;
Image image2 = new Image(0, "Javaone Keynote", "B", 0, Image.Size.SMALL)
;

Note that the URIs are "A" nd "B", which is much shorter than the URIs used
in the ThriftSerializer and the ProtobufSerializer.

These and any other inconsistencies should be corrected so the tests can be
truly apples-to-apples.

Original issue reported on code.google.com by chad_wal...@yahoo.com on 13 May 2009 at 8:27

GoogleCodeExporter commented 8 years ago
Fixed the two problems specified, in SVN 82.

Original comment by nathan.s...@gmail.com on 29 Sep 2009 at 4:07