search

sunnysideup / silverstripe-sharethis

adds a bunch of social media tools to your Silverstripe website
www.silverstripe-webdevelopment.com
Other
4 stars 5 forks source link

Request #2

Open hp7 opened 9 years ago

hp7 commented 9 years ago

Anyway to add a field to insert css class and wrap links in tags, so instead of using icons in current system user can use Font Awesome to supply icons. Many benefits to this (icon and css attribute scaling, uniform design, less work updating your icon library, etc) See info on Font Awesome http://fortawesome.github.io/Font-Awesome/

sunnysideup commented 9 years ago

Hi

I think thiat is a great idea. The only pitfall is that the css may be a bit bigger, otherwise it has like a billion advantages.

Would you like to have input / help a little in doing this?

I am definitely in favour and I thank you very much for the idea!

Nicolaas

sunnysideup commented 9 years ago

I have had a first go at implementing this....

hp7 commented 9 years ago

Thanks Nicolaas I also tried but I'm not a programmer. I will take a look this weekend. Maybe I can help I'm new to Git so it will be slow

Sent from my iPhone

On Oct 25, 2014, at 3:21 AM, Nicolaas notifications@github.com wrote:

I have had a first go at implementing this....

— Reply to this email directly or view it on GitHub.

sunnysideup commented 9 years ago

Hi HP7

Would you be interested in just doing some testing on the module. Just to see that it all works for you. In about five hours from now, git will be up-to-date wit the new code.

Cheers

Nicolaas

hp7 commented 9 years ago

Sure. Thanks

Sent from my iPhone

On Oct 25, 2014, at 4:39 PM, Nicolaas notifications@github.com wrote:

Hi HP7

Would you be interested in just doing some testing on the module. Just to see that it all works for you. In about five hours from now, git will be up-to-date wit the new code.

Cheers

Nicolaas

— Reply to this email directly or view it on GitHub.

hp7 commented 9 years ago

Code seems to work for one of the components, but think their is a CSS conflict between Font Awesome CSS and SS Default temp .typography ul & .content ul I'm in the middle of a project when I have sometime Ill take another look. I modified for my use it's at HP7 fork. Thanks for your hard work