search

sunodo / sunodo

Sunodo monorepo
https://docs.sunodo.io
Apache License 2.0
30 stars 26 forks source link

Refactor/sunodo build simpler execa calls #421

Closed endersonmaia closed 1 month ago

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 21, 2024 7:04pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 7:04pm
changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 3f5536bf6ecda449a01d61e5ac1e602d5df010f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tuler commented 2 months ago

What I don’t like in that direction is that IMO this increases maintenance effort instead of reducing, because it adds up another layer of variables names (environment variables in this case) that we need to take care to update in two different places.

tuler commented 2 months ago

It would be different if the binaries we use supported env variables, then it would just be a passthrough of the variables.

endersonmaia commented 2 months ago

Still a draft...

I have another PR where I try to wrap the calls inside a generic command API, that could be another way of doing that