sunpy / ablog

ABlog for blogging with Sphinx
https://ablog.readthedocs.io/
Other
184 stars 55 forks source link

Make '_strip' function return as list not set. #280

Closed JoeZiminski closed 6 months ago

JoeZiminski commented 6 months ago

PR Description

Closes #279. This PR changes the return type of _strip function in blog.py to a list rather than set. This ensures the order of values specified in the blog (e.g. :author:) is maintained on the postlist.

nabobalis commented 6 months ago

Thanks for the PR!

nabobalis commented 6 months ago

Those CI fails are to be expected (I need to fix them separately).

nabobalis commented 6 months ago

I will merge this and get a release out.

JoeZiminski commented 6 months ago

Awesome, thanks @nabobalis!

nabobalis commented 6 months ago

0.11.9 should be out now, so you can test your blog with that version and see if that solves your problem.

JoeZiminski commented 6 months ago

This is working great, thanks @nabobalis !

nabobalis commented 6 months ago

Thank you for submitting the PR