Use np.all instead of all

sunpy / ndcube

A base package for multi-dimensional contiguous and non-contiguous coordinate-aware arrays.

http://docs.sunpy.org/projects/ndcube/

BSD 2-Clause "Simplified" License

44 stars 48 forks source link

Closed nabobalis closed 4 months ago

nabobalis commented 4 months ago

This line errors if binshape is a quantity.

(Pdb) bin_shape
<Quantity [2, 2] pix>
(Pdb) bin_shape == 1
False
(Pdb) all(bin_shape == 1)
*** TypeError: 'bool' object is not iterable

Cadair commented 4 months ago

How is this line not covered by tests? :eyes: did codecov melt again?

Cadair commented 4 months ago

oh so your website and check say it is but you still put the annotation on the code. Gee thanks