search

sunpy / ndcube

A base package for multi-dimensional contiguous and non-contiguous coordinate-aware arrays.
http://docs.sunpy.org/projects/ndcube/
BSD 2-Clause "Simplified" License
44 stars 48 forks source link

Rough attempt at ignoring units for rebin #744

Closed nabobalis closed 4 months ago

nabobalis commented 4 months ago

One way to do it.

Context: sunpy.map.superpixel requireds astropy units as input.

rebin does not enforce this but a lot of superpixel code has units attached, so making that work with those would be a better idea than making users drop the pixel units.

Cadair commented 4 months ago

@DanRyanIrish do you have philosophical objections to this?

nabobalis commented 4 months ago

I just spoke to him via carrier pigeon, he said he approves.

DanRyanIrish commented 4 months ago

@DanRyanIrish do you have philosophical objections to this?

I'm ok with this