Small misconfigurations in setup.cfg and project.toml - Githubissues

sunpy / package-template

A cookiecutter template for packages that want to have a similar setup to sunpy

2 stars 4 forks source link

Small misconfigurations in setup.cfg and project.toml #20

Closed samaloney closed 4 months ago

samaloney commented 3 years ago

Description

Clean package using template

setup.cfg doesn't have include_package_data = True so the 'MANIFEST.in' file is ignored
Towncrier config seems to use the project name ('MyProject') rather than default generate package name ('myproject') so can't find the what's new.

Expected vs Actual behavior

Maybe either don't include the manifest file or include_package_data = True in setup.cfg
Update the template to use the package not project name?

Steps to Reproduce

System Details

SunPy Version:
Astropy Version:
Python Version:
OS information:

nabobalis commented 3 years ago

This is fixed upstream by https://github.com/OpenAstronomy/packaging-guide/pull/13, hopefully when that is merged, we can merge it here.
Is fixed by https://github.com/sunpy/package-template/pull/21