search

sunpy / sunkit-image

A image processing toolbox for Solar Physics
https://docs.sunpy.org/projects/sunkit-image/en/stable/
BSD 2-Clause "Simplified" License
35 stars 45 forks source link

De-Class NoiseLevelEstimation #18

Closed nabobalis closed 5 years ago

nabobalis commented 5 years ago

Description

When #12 is merged in, I propose turning NoiseLevelEstimation into a series of functions and not a class.

MSKirk commented 5 years ago

I agree on this front. There are several noise level estimation routines that are appropriate for use in solar images. I think a series of functions would better represent these.

m-squared96 commented 5 years ago

Hey, just a heads up. I'm a GSoC hopeful and I'm attempting to fix this issue. Currently WIP. I have the original NoiseLevelEstimation object "de-classed" and now I just need to test to make sure functionality has remained the same.

dpshelio commented 5 years ago

I would take a different approach. I would have a denoise class and different functions as different strategies, that is how the strategy pattern works. This is the implementation on a solar physics example.

nabobalis commented 5 years ago

So we just refactor the class to enable someone to add more functions?