search

sunpy / sunkit-image

A image processing toolbox for Solar Physics
https://docs.sunpy.org/projects/sunkit-image/en/stable/
BSD 2-Clause "Simplified" License
36 stars 46 forks source link

Enable enhanced Ruff linting #241

Closed CyclingNinja closed 5 days ago

CyclingNinja commented 2 weeks ago

As part of the ongoing efforts to align The SunPy Community's package infrastructure across all sub packages, we are moving all repos to the same linting and formatting rule set.

In order to update the repo the following steps need to be taken.

1.. Update the use_extended_ruff_linting variable from n to y (you will need cruft installed)

$ cruft update --variables-to-update '{"use_extended_ruff_linting": "y"}'

  1. Locally format your code using tox -e codestyle

  2. You can use ruff check --unsafe-fixes cli tool to correct a great deal of the formatting with minimal interruption

  3. Fix the remaining linting or formatting.

  4. PR :tada:

Abinash-bit commented 1 week ago

Hey @CyclingNinja can you say where i can find use_extended_ruff_linting variable , like in which file of the sunkit-image?

nabobalis commented 1 week ago

That line is in https://github.com/sunpy/sunkit-image/blob/main/.cruft.json#L19