Fixing Fermi plot_detector_sun_angles

sunpy / sunkit-instruments

A SunPy-affiliated package for solar instrument-specific tools.

https://docs.sunpy.org/projects/sunkit-instruments/

BSD 3-Clause "New" or "Revised" License

11 stars 15 forks source link

Fixing Fermi plot_detector_sun_angles #130

Closed aringlis closed 3 months ago

aringlis commented 3 months ago

The function plot_detector_sun_angles was broken, due to the formatting of the time axis. This was reported in #71.

This PR proposes a fix by reformatting the time axis as datetimes, which matplotlib accepts. Also tidied up the location of the legend to be outside the plotting area.

Fixes #71

nabobalis commented 3 months ago

We have no unit tests for any of this. That will have to come in a new PR when I add support for figure tests.

nabobalis commented 3 months ago

Thanks for the fix @aringlis