High-energy break of `thick_fn` should not be 150 keV

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy

BSD 3-Clause "New" or "Revised" License

22 stars 26 forks source link

High-energy break of `thick_fn` should not be 150 keV #112

Closed settwi closed 11 months ago

settwi commented 1 year ago

Describe the bug

See here

The high-energy break (?) of the thick target single power law emission function is locked to 150 keV. for RHESSI flares where the emission extends beyond 150 keV the break should be variable.

Proposed fix: make it so the break energy takes the max of the given energy array and multiplies it by 10, or something like that.

To Reproduce

No response

Screenshots

No response

System Details

No response

Installation method

No response

settwi commented 1 year ago

Does the thick target function thick_fn have a test associated with it? I am gonna link a PR. Seems like there aren't any official tests associated with thick_fn, unless I'm missing something.