search

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Rhessi srm editable #117

Closed settwi closed 5 months ago

settwi commented 1 year ago

Addresses #116 by modifying RhessiLoader with extra kwarg. Example in the examples folder too.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage is 6.12% of modified lines.

Files Changed Coverage
sunxspex/sunxspex_fitting/instruments.py 0.00%
sunxspex/sunxspex_fitting/rhes_spec_code.py 6.06%
sunxspex/sunxspex_fitting/io.py 8.33%

:loudspeaker: Thoughts on this report? Let us know!.

settwi commented 11 months ago

@KriSun95, @ianan, @LinErinG -- i updated this to auto-pick the RHESSI SRM in the specified spectroscopy interval. it also raises a warning if you span two intervals with an attenuator state change.

this is not in the style of the new refactor but rather a bandaid fix so that i don't have to keep struggling with a jerry-rigged API for a paper i am working on :p

settwi commented 5 months ago

Annoying conflicts post-package rename so i am opening a new draft pr