search

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Only pass instrument loader #120

Closed KriSun95 closed 1 month ago

KriSun95 commented 1 year ago

Separate more of the instrument specific code from the more general fitting code. Remove the ability to pass files and dictionaries directly to the fitter. instead, the files (or dictionaries) can be passed to instrument specific (or custom) loaders and then passed to the fitting code.

This is to address #119 in order to support a more modular approach to the code and reduce complexity (also pointed out in #107).

codecov-commenter commented 1 year ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
sunxspex/sunxspex_fitting/data_loader.py 17.04% <88.88%> (-1.39%) :arrow_down:
sunxspex/sunxspex_fitting/fitter.py 54.10% <66.66%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.

settwi commented 4 months ago

how about we implement this in "legacy"? might make our lives nicer down the road :p