sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Maintenance update min python versions and add testing for newer versions #121

Closed samaloney closed 11 months ago

samaloney commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
sunkit_spex/__init__.py 100.00% <ø> (ø)
sunkit_spex/constants.py 88.88% <ø> (ø)
sunkit_spex/emission.py 92.20% <100.00%> (ø)
sunkit_spex/integrate.py 96.00% <ø> (ø)
sunkit_spex/io.py 89.07% <ø> (ø)
sunkit_spex/logging.py 100.00% <ø> (ø)
sunkit_spex/photon_power_law.py 97.77% <ø> (ø)
sunkit_spex/sunxspex_fitting/__init__.py 100.00% <ø> (ø)
sunkit_spex/sunxspex_fitting/data_loader.py 18.42% <100.00%> (ø)
sunkit_spex/sunxspex_fitting/fitter.py 54.10% <100.00%> (ø)
... and 10 more

:loudspeaker: Thoughts on this report? Let us know!.

hayesla commented 1 year ago

do you want to have this rename as part of this PR aswell or keep it separate to #114 or what order do you want?

samaloney commented 1 year ago

I'd planned to rebase this once #114 is merged

samaloney commented 1 year ago

All green - that was a bit of a journey, after #114 is merged and I rebase the changelog number problem should go away 🤞

settwi commented 1 year ago

Upgrading to 3.9 also relevant for #124 :-) using a_dict | other_dict