search

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Changing sunxspex_fitting to fitting? #131

Closed ianan closed 7 months ago

ianan commented 11 months ago

Describe the feature

Despite the name change we still have fitting called sunxspex_fitting, i.e. from sunkit_spex.sunxspex_fitting.fitter import Fitter

Proposed solution

Maybe better to just call it fitting, so would do from sunkit_spex.fitting.fitter import Fitter ?

samaloney commented 8 months ago

I guess this can be close when #137 is merged will be from sunkit.fitting_legacy import Fitter

settwi commented 8 months ago

@samaloney let's close this?

settwi commented 7 months ago

@KriSun95 close?

KriSun95 commented 7 months ago

@KriSun95 close?

Yes, and thanks to @ianan for opening this!