search

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Rename sunxspex_fitting module to fitting. #133

Closed DanRyanIrish closed 6 months ago

DanRyanIrish commented 9 months ago

PR Description

As described in PR title. Justification is that the package is no longer called sunxspex and there's no need for a module to carry the name of the package.

DanRyanIrish commented 9 months ago

ping @ianan

settwi commented 9 months ago

How about legacy_fitter? :-)

DanRyanIrish commented 9 months ago

Ah, I see @samaloney. So you suggest not merging this PR and keeping it as is. Then we can create a new fitting module for the refactored fitting?

samaloney commented 9 months ago

Essentially, but happy to merge this PR just with a different name to make it easier during the refactor e.g. support both for while

DanRyanIrish commented 9 months ago

Perhaps it's easier for backwards compatibility to keep the name as is and then deprecate it once the new fitting module is ready.

KriSun95 commented 9 months ago

I like the idea of changing it to something generic like legacy_fitter, purely because of the past confusion in the naming. Since most of the name change has already taken place, and only just, I'm personally not as worried as much about this edit affecting backwards compatibility.

samaloney commented 6 months ago

Is this necessary with #137?