sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Quick fix to breaking bug from thermal model #134

Closed KriSun95 closed 7 months ago

KriSun95 commented 9 months ago

When changing the chianti file for the thermal model, the fitter test on the user model can fail. Real issue is in thermal model which the testing energy range in the fitter fails on. This PR changes testing energy range to not get caught in thermal function bug.

This is a quick fix which does not get at the real issue; however, it avoids the bug now and stops the fitter from breaking as described in #99. Additionally, this issue will be more fully dealt with during more refactoring of the package.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@2deabc0). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #134 +/- ## ======================================= Coverage ? 55.81% ======================================= Files ? 20 Lines ? 3166 Branches ? 0 ======================================= Hits ? 1767 Misses ? 1399 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.