search

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Fitter legacy #137

Closed KriSun95 closed 6 months ago

KriSun95 commented 6 months ago

Changing sunxspex_fitting to fitting_legacy and adding new fitting module.

codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@2257afb). Click here to learn what that means.

Files Patch % Lines
sunkit_spex/fitting_legacy/fitter.py 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #137 +/- ## ======================================= Coverage ? 55.81% ======================================= Files ? 20 Lines ? 3166 Branches ? 0 ======================================= Hits ? 1767 Misses ? 1399 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KriSun95 commented 6 months ago

I've made changes to the changelog and also added the fitting module. Thanks to @samaloney for handling the update to match main!