Rhessi srm editable (post rename)

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy

BSD 3-Clause "New" or "Revised" License

22 stars 26 forks source link

Rhessi srm editable (post rename) #143

Closed settwi closed 3 months ago

settwi commented 4 months ago

Addresses issue #116 by

auto-picking the correct RHESSI SRM based on the selected time range of the data.
making it easy to add systematic error e.g.: sunkit_fitter.systematic_error = 0.1

Also deletes the STIX loader. I think I did that in the past when I was frustrated with how it (didn't really) work. We should probably add that back before this gets merged... if it ever does :p

This change makes it actually possible to do good analysis on RHESSI data. I am going to use this branch in a paper so it would be great if we could get the changes merged in.

- WS

codecov-commenter commented 4 months ago

Files	Patch %	Lines
sunkit_spex/fitting_legacy/instruments.py	50.00%	1 Missing :warning:

```diff @@ Coverage Diff @@ ## main #143 +/- ## ======================================= Coverage ? 61.21% ======================================= Files ? 18 Lines ? 2741 Branches ? 0 ======================================= Hits ? 1678 Misses ? 1063 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KriSun95 commented 3 months ago

This PR is looking good. Would it be worth while creating the extern module in fitting_legacy and moving the RHESSI code there in this PR as well?

samaloney commented 3 months ago

This PR is looking good. Would it be worth while creating the extern module in fitting_legacy and moving the RHESSI code there in this PR as well?

The extern module is already there just need to move the code and maybe convert the ipynb to py for easier diffs or at least strip out the cell outputs.