search

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Ruff lint and format, isort, codespell #152

Closed samaloney closed 2 months ago

samaloney commented 3 months ago

Add ruff lint and format, sort and code spell to pre-commit and make all pass

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 37.17949% with 196 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@45c147e). Learn more about missing BASE report.

Files Patch % Lines
sunkit_spex/legacy/emission.py 13.23% 59 Missing :warning:
sunkit_spex/legacy/thermal.py 30.43% 32 Missing :warning:
sunkit_spex/models/physical/thermal.py 30.43% 32 Missing :warning:
...unkit_spex/legacy/fitting_legacy/rhes_spec_code.py 0.00% 18 Missing :warning:
...it_spex/legacy/fitting_legacy/parameter_handler.py 54.83% 14 Missing :warning:
...unkit_spex/legacy/fitting_legacy/stix_spec_code.py 0.00% 9 Missing :warning:
sunkit_spex/legacy/photon_power_law.py 0.00% 9 Missing :warning:
sunkit_spex/legacy/fitting_legacy/nu_spec_code.py 0.00% 5 Missing :warning:
...legacy/fitting_legacy/photon_models_for_fitting.py 20.00% 4 Missing :warning:
sunkit_spex/legacy/constants.py 50.00% 3 Missing :warning:
... and 6 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ======================================= Coverage ? 49.89% ======================================= Files ? 25 Lines ? 3403 Branches ? 0 ======================================= Hits ? 1698 Misses ? 1705 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

settwi commented 3 months ago

sweet! if you run pre-commit locally does it now call ruff?

samaloney commented 3 months ago

if you run pre-commit locally does it now call ruff?

Yea that's the idea, so once this is merged it should.

samaloney commented 2 months ago

The test fail is due to numpy2.0 removal so I think can be ignored for now

samaloney commented 2 months ago

Again windows test fail is unrelated - maybe getting blocked by hesperia for too many downloads

samaloney commented 2 months ago

Ha I think if there was a typo award I would get it - worst thing this doesn't even catch them all.