sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

WIP Convert notebooks to gallery examples #153

Open samaloney opened 3 months ago

samaloney commented 3 months ago

Convert notebooks to gallery file so they can be run as part of the docs build.

There's a fair amount of overlap in the different examples should discuss what we should do, we could split into feature examples and papers recreations?

Also as far as I can see the current code doesn't always match what was in the tables 😬

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@45c147e). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #153 +/- ## ======================================= Coverage ? 49.89% ======================================= Files ? 25 Lines ? 3403 Branches ? 0 ======================================= Hits ? 1698 Misses ? 1705 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

settwi commented 3 months ago

is there a central spot we can put data files? i have some on a GDrive but that isn't exactly ideal

samaloney commented 2 months ago

is there a central spot we can put data files? i have some on a GDrive but that isn't exactly ideal

Eh good question, at the moment I don't think we have one. I just put them somewhere the individual files could be downloaded rather than a zip.