search

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Refactor redundant legacy #158

Closed samaloney closed 1 month ago

samaloney commented 3 months ago

Remove redundant 'legacy' in module from ~sunkit_spex.legacy.fitting_legacy to sunkit_spex.legacy.fitting.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 38.88889% with 66 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@3a9a4a4). Learn more about missing BASE report.

Files Patch % Lines
sunkit_spex/legacy/fitting/data_loader.py 10.34% 52 Missing :warning:
sunkit_spex/legacy/fitting/instruments.py 38.09% 13 Missing :warning:
sunkit_spex/legacy/fitting/fitter.py 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #158 +/- ## ======================================= Coverage ? 60.50% ======================================= Files ? 25 Lines ? 3408 Branches ? 0 ======================================= Hits ? 2062 Misses ? 1346 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samaloney commented 3 months ago

Note I haven't update the notebooks as they will be removed in #153

samaloney commented 1 month ago

Reviews please

nabobalis commented 1 month ago

Why was it called legacy originally?

samaloney commented 1 month ago

Needed a way to delineate older code which won't be updated and will eventually be removed from what we are now trying to do