search

sunpy / sunkit-spex

:construction: Under Development :construction: A package for solar X-ray spectroscopy
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Feat testing #75

Closed samaloney closed 1 year ago

samaloney commented 2 years ago

PR Description

  1. Add some basic tests around fitting using custom data
  2. Refactor fitter to not use globals as much and keep models, parameter on instances of the class3.
    • Update dependant code (as much as I could find)
  3. Move away from print statements to logging
codecov-commenter commented 2 years ago

Codecov Report

Merging #75 (2534ddb) into master (818ae4f) will increase coverage by 22.13%. The diff coverage is 49.69%.

@@             Coverage Diff             @@
##           master      #75       +/-   ##
===========================================
+ Coverage   32.50%   54.63%   +22.13%     
===========================================
  Files          18       19        +1     
  Lines        3098     3115       +17     
===========================================
+ Hits         1007     1702      +695     
+ Misses       2091     1413      -678
Impacted Files Coverage Δ
sunxspex/sunxspex_fitting/fitter.py 53.59% <45.69%> (+40.32%) :arrow_up:
sunxspex/logging.py 100.00% <100.00%> (ø)
sunxspex/sunxspex_fitting/data_loader.py 17.22% <100.00%> (+4.49%) :arrow_up:
sunxspex/emission.py 92.20% <0.00%> (-0.46%) :arrow_down:
sunxspex/sunxspex_fitting/instruments.py 21.89% <0.00%> (+3.64%) :arrow_up:
sunxspex/sunxspex_fitting/likelihoods.py 68.57% <0.00%> (+20.00%) :arrow_up:
sunxspex/sunxspex_fitting/parameter_handler.py 71.34% <0.00%> (+52.04%) :arrow_up:
sunxspex/sunxspex_fitting/rainbow_text.py 82.35% <0.00%> (+70.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 818ae4f...2534ddb. Read the comment docs.