sunpy / sunpy-1.0-paper

The SunPy 1.0 Paper Repo
12 stars 21 forks source link

Edits after thorough read through #113

Closed wtbarnes closed 5 years ago

wtbarnes commented 5 years ago

This PR is ready for review.

This PR consists of edits throughout the text of the paper, including some reorganizing of the sections. I've summarized the major changes below.

I've isolated changes to each section to their own commit so this can be broken up if need be.

Also fixes #87

Major Changes

ayshih commented 5 years ago
  • Removed "Differential Rotation" section, including the figure.

I'm not particularly attached to this section/figure, but has there been broad agreement to removing it?

wtbarnes commented 5 years ago

@ayshih I'm not sure, but perhaps we can have that discussion on this PR or during the telecon on Wednesday.

I'm happy to add it back in if people really want it, or if there are suggestions about how to better integrate it into an existing section.

I removed it because it doesn't really make sense for it to have its own section and it does not fit in the coordinates section either.

ehsteve commented 5 years ago

I'm not a big fan or removing the differential rotation section and figure either.

wtbarnes commented 5 years ago

I'm not a big fan or removing the differential rotation section and figure either.

Do you have a suggestion of where it should go? It seems strange to give it its own section, but it also does not really fit in the coordinates section. If the consensus is to leave it as is in its own section under coordinates, that's fine, but it just seems a bit awkward.

nabobalis commented 5 years ago

Closed in favour of #115 as it has all of the commits.