search

sunpy / sunpy-1.0-paper

The SunPy 1.0 Paper Repo
12 stars 21 forks source link

GOES time series plot and peek() #136

Closed ehsteve closed 5 years ago

ehsteve commented 5 years ago

Figure 2 does not use peek() and so we are not using the opportunity to show off the visualization aspect of time series. Peek() provides the goes class defined y axis.

hayesla commented 5 years ago

Well I feel like for figure worthy plots it better to use plot as you have more control over just using the peek() functionality - isn't peek rather actually inspecting the data?

ehsteve commented 5 years ago

Yes, you are right that peek is not really meant to be used to make figures. The thing that bothers me the most is the GOES class axis is not represented here. I'm mostly fine with not using peek(). It might be good to break out the function that adds that axis as a helper function in SunPy but that is a comment for another repo!

hayesla commented 5 years ago

That's true - we can add that in though - should we update the figure to this

timeseries_example2