sunpy / sunpy-1.0-paper

The SunPy 1.0 Paper Repo
12 stars 21 forks source link

edited intro for english + logical flow #147

Closed mbobra closed 5 years ago

mbobra commented 5 years ago

Here is a summary of the changes:

nabobalis commented 5 years ago

I take the word faster there to refer to mean faster to develop code over fortran.

mbobra commented 5 years ago

I take the word faster there to refer to mean faster to develop code over fortran.

Ah okay, I think it makes sense to clarify that.

wtbarnes commented 5 years ago

After my deep dive into the abbreviations, I will nitpick about adding SSW. Since we don't use SSW anywhere else in the paper, there's really no need to include the abbreviation.

wtbarnes commented 5 years ago

Thanks for this @mbobra. I think your discussion about open development fits well into that paragraph.

wtbarnes commented 5 years ago

One last nitpick not related to your changes here: In the very last paragraph of the intro, can you change "v0.5" to "version 0.5"? I fixed inconsistent use of v, V, version everywhere else in the paper, but it looks like I missed this one.

ehsteve commented 5 years ago

I'll accept this PR and I'll go ahead and address your issues @wtbarnes.