search

sunpy / sunpy-1.0-paper

The SunPy 1.0 Paper Repo
12 stars 21 forks source link

Fido and `drms` #150

Closed ayshih closed 4 years ago

ayshih commented 5 years ago

The paper is confusing/misleading about drms and its relationship to the core package. The Fido section (4.1.1) takes credit for providing access to JSOC, but doesn't mention drms at all. In the drms section (6.1), the description gives no indication that drms is actually a dependency of Fido's aforementioned JSOC capability.

mbobra commented 5 years ago

drms does not depend on Fido.

ayshih commented 5 years ago

Huh? I'm saying that Fido depends on drms for JSOC capability.

ehsteve commented 5 years ago

This has not been resolved in the submitted version so keeping this open to fix when we get reviewer comments back.

ehsteve commented 4 years ago

In the proof, added a line to the dmrs package section at the end "\Fido depends on this package to enable it to access JSOC search results." Also added text to the Fido section "thanks to the \package{drms} affiliated package see Section..."