search

sunpy / sunpy-1.0-paper

The SunPy 1.0 Paper Repo
12 stars 21 forks source link

Added figure 1 caption, tidied up the latex files and python files, added a Makefile #26

Closed nabobalis closed 5 years ago

nabobalis commented 5 years ago

I added a caption to figure one.

So let us talk about figure 1.

I feel that figure 1 (a) and (c) could be merged into one. I can not find the code for figure 1 (a) to check what the lines are (do we want a legend?). They need to be updated for 1.0 as well.

I also just went through some of the latex files and replaced SunPy with \sunpy and any lines that there not one sentence per line. Also vscode got to the files removing extra whitespace. Enabling the hide whitespace changes filter makes the diff much smaller for review. Further, I just made sure that the setup_plot is called in all the python files and updated any figures that changed as a result.

I split the commits just in case.

I also added a Makefile to create the pdf (via the astropy repo one). Fixes #19 There is one issue with it, that fig_coronagraph_starfield.pdf is saved in the higher level folder than the figure folder and I can not work out why.