search

sunpy / sunpy-soar

A sunpy plugin for accessing data in the Solar Orbiter Archive (SOAR).
https://docs.sunpy.org/projects/soar/
BSD 2-Clause "Simplified" License
17 stars 10 forks source link

Remove the identifier attrs #102

Closed hayesla closed 11 months ago

hayesla commented 11 months ago

Fixes #100

Its been deprecated for quite a while (since 1.2).

nabobalis commented 11 months ago

I think a removal changelog would be nice.

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
sunpy_soar/__init__.py 100.00%
sunpy_soar/attrs.py 100.00%
sunpy_soar/client.py 100.00%
sunpy_soar/tests/test_sunpy_soar.py 100.00%

:loudspeaker: Thoughts on this report? Let us know!.

wtbarnes commented 11 months ago

Test fail is real. The __init__ still has an import statement for identifier