search

sunpy / sunpy-soar

A sunpy plugin for accessing data in the Solar Orbiter Archive (SOAR).
https://docs.sunpy.org/projects/soar/
BSD 2-Clause "Simplified" License
18 stars 12 forks source link

Name of attribute Identifier and corresponding column in results table 'Data Product' differs. #12

Closed samaloney closed 3 years ago

samaloney commented 3 years ago

The name of the column in the search table and the attribute used to search for that seem to differ in name but not sure if they are the same?

result = Fido.search(Time('2021-01-01', '2021-01-15') & Instrument('RPW'))

result
<sunpy.net.fido_factory.UnifiedResponse object at 0x1179d7b70>
Results from 1 Provider:

465 Results from the SOARClient:
Instrument     Data product    Level        Start time               End time         Filesize
---------- ------------------- ----- ----------------------- ----------------------- ---------
       RPW                 rpw    L0 2021-01-15 00:00:00.000 2021-01-16 00:00:00.000 1263.4 MB
       RPW                 rpw    L0 2021-01-14 00:00:00.000 2021-01-15 00:00:00.000 1066.8 MB
       RPW                 rpw    L0 2021-01-13 00:00:00.000 2021-01-14 00:00:00.000  855.1 MB
       RPW                 rpw    L0 2021-01-12 00:00:00.000 2021-01-13 00:00:00.000 1000.4 MB
       RPW                 rpw    L0 2021-01-11 00:00:00.000 2021-01-12 00:00:00.000 1153.2 MB
       RPW                 rpw    L0 2021-01-10 00:00:00.000 2021-01-11 00:00:00.000  958.9 MB
       RPW                 rpw    L0 2021-01-09 00:00:00.000 2021-01-10 00:00:00.000 1063.8 MB
       ...                 ...   ...                     ...                     ...       ...
       RPW        RPW-TNR-SURV    L1 2021-01-11 00:00:00.000 2021-01-12 00:00:00.000   42.4 MB
       RPW   RPW-TDS-SURV-MAMP    L1 2021-01-11 00:00:00.000 2021-01-12 00:00:00.000  351.4 MB
       RPW        RPW-HFR-SURV    L1 2021-01-11 00:00:00.000 2021-01-12 00:00:00.000  243.7 MB
query = Fido.search(a.Time('2020-07-11', '2020-07-11 23:59'), a.Instrument('RPW'),
                                   Identifier('RPW-HFR-SURV'))

query
<sunpy.net.fido_factory.UnifiedResponse object at 0x116ce2518>
Results from 1 Provider:

2 Results from the SOARClient:
Instrument Data product Level        Start time               End time        Filesize
---------- ------------ ----- ----------------------- ----------------------- --------
       RPW RPW-HFR-SURV    L2 2020-07-11 00:00:00.000 2020-07-12 00:00:00.000 365.3 MB
       RPW RPW-HFR-SURV    L1 2020-07-11 00:00:00.000 2020-07-12 00:00:00.000 322.7 MB
dstansby commented 3 years ago

Thanks for the report - in retrospect Indentifier isn't the best name... I'm keen to change it, do you have any suggestions? Perhaps Product?

dstansby commented 3 years ago

Or Dataset?

samaloney commented 3 years ago

Yea I'm not too sure I would lean towards Product over Dataset as it is a bit less specific