search

sunpy / sunpy-soar

A sunpy plugin for accessing data in the Solar Orbiter Archive (SOAR).
https://docs.sunpy.org/projects/soar/
BSD 2-Clause "Simplified" License
18 stars 12 forks source link

Register valid values with a.soar.Product attribute #36

Closed dstansby closed 2 years ago

dstansby commented 2 years ago

Fixes https://github.com/sunpy/sunpy-soar/issues/33. I still need to work out how to add info from the FITS table to this.

ebuchlin commented 2 years ago

Yes, fits_dataset exists in SOAR TAP tables, but is missing some information present in cdf_dataset.

dstansby commented 2 years ago

I just took another look at this, and as you say there's not as much info in fits_dataset, in particular there doesn't seem to be a column we can use as the dataset description:

Screenshot 2022-08-29 at 16 33 08

For now I might just scrape the dataset names without a description, as that's still an improvement.

codecov-commenter commented 2 years ago

Codecov Report

Base: 97.44% // Head: 97.63% // Increases project coverage by +0.18% :tada:

Coverage data is based on head (05350d9) compared to base (9e657a2). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== + Coverage 97.44% 97.63% +0.18% ========================================== Files 4 4 Lines 196 211 +15 ========================================== + Hits 191 206 +15 Misses 5 5 ``` | [Impacted Files](https://codecov.io/gh/sunpy/sunpy-soar/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sunpy) | Coverage Δ | | |---|---|---| | [sunpy\_soar/client.py](https://codecov.io/gh/sunpy/sunpy-soar/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sunpy#diff-c3VucHlfc29hci9jbGllbnQucHk=) | `100.00% <100.00%> (ø)` | | | [sunpy\_soar/tests/test\_sunpy\_soar.py](https://codecov.io/gh/sunpy/sunpy-soar/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sunpy#diff-c3VucHlfc29hci90ZXN0cy90ZXN0X3N1bnB5X3NvYXIucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sunpy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sunpy)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nabobalis commented 2 years ago

Worth a unit test to check at least one product attr was registered?