sunpy / sunpy-soar

A sunpy plugin for accessing data in the Solar Orbiter Archive (SOAR).
https://docs.sunpy.org/projects/soar/
BSD 2-Clause "Simplified" License
17 stars 11 forks source link

Updating to sunpy_soar==1.5 issue #54

Closed hayesla closed 1 year ago

hayesla commented 1 year ago

Describe the bug

I just updated to the latest release (1.5) and get the following error:

>>> import sunpy_soar
FileNotFoundError: [Errno 2] No such file or directory: '/Users/laura.hayes/opt/miniconda3/lib/python3.9/site-packages/sunpy_soar/data/attrs.json'

when downgrading to 1.4, this is not an issue. Maybe something to do with release yesterday?

dstansby commented 1 year ago

Ahhhhh thanks for reporting, just seen this in the conda build too. I'm guessing the new attrs.json file isn't being packaged, will take a look now.

dstansby commented 1 year ago

@hayesla is this working for you now? I'm still seeing issues on conda, but I think this should be fixed in the pypi pacakge...

dstansby commented 1 year ago

Sigh, I don't think I fixed it right

hayesla commented 1 year ago

no still not working unfortunately

dstansby commented 1 year ago

Sigh, is it working now in 1.5.2? I've tested the PyPi release locally and it seems to, but will let you close this issue yourself once you've checked it's fixed 😄

hayesla commented 1 year ago

working now - thanks @dstansby !