search

sunpy / sunpy-soar

A sunpy plugin for accessing data in the Solar Orbiter Archive (SOAR).
https://docs.sunpy.org/projects/soar/
BSD 2-Clause "Simplified" License
17 stars 11 forks source link

SOARClient returns (empty) results for non-solo queries #59

Closed alasdairwilson closed 1 year ago

alasdairwilson commented 1 year ago

Describe the bug

If you import sunpy-soar then all subsequent Fido queries will have a SOARClient results table even when it non SolO attrs are set.

To Reproduce

import sunpy_soar
from sunpy.net import Fido, attrs as a

r = Fido.search(a.Instrument.aia, a.Time('2022-10-7T00:00:00','2022-10-07T00:00:10'))

<sunpy.net.fido_factory.UnifiedResponse object at 0x000001C19672F1C0>
Results from 2 Providers:

10 Results from the VSOClient:
Source: http://vso.stanford.edu/cgi-bin/search
Total estimated size: 42.107 Mbyte

       Start Time               End Time        ...             Info
                                                ...
----------------------- ----------------------- ... ----------------------------
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024
2022-10-07 00:00:00.000 2022-10-07 00:00:00.000 ... AIA level 1.5 NRT, 1024x1024

0 Results from the SOARClient:

Instrument Data product Level Start time End time Filesize
                                                   Mbyte
---------- ------------ ----- ---------- -------- --------

Screenshots

No response

System Details

No response

Installation method

No response

dstansby commented 1 year ago

Thanks for reporting! To fix this I think we're going to need to fix https://github.com/sunpy/sunpy-soar/issues/52, and then we can filter out any queries that include non-solar orbiter instruments in _can_handle_query.