search

sunpy / sunpy-soar

A sunpy plugin for accessing data in the Solar Orbiter Archive (SOAR).
https://docs.sunpy.org/projects/soar/
BSD 2-Clause "Simplified" License
17 stars 11 forks source link

Adding ability to query over SOOP name #84

Closed hayesla closed 1 year ago

hayesla commented 1 year ago

PR Description

This PR adds a new attrs a.soar.SOOP and allows the users to construct a query based on a SOOP name.

Fixes #73

hayesla commented 1 year ago

I guess a question here - should we remove that a.Time is a required attr? I could imagine a case when someone just wants to query solely based on SOOP for example.

nabobalis commented 1 year ago

I guess a question here - should we remove that a.Time is a required attr? I could imagine a case when someone just wants to query solely based on SOOP for example.

Sounds sensible to me.

Could we get a attrs unit test for soup and maybe a query for some soop search results?

nabobalis commented 1 year ago

Thanks for doing this @hayesla. I have tagged 1.8 as well, so it should be public soon.