Fixing upper case to lower case descriptors (products) for SOAR 1.11

sunpy / sunpy-soar

A sunpy plugin for accessing data in the Solar Orbiter Archive (SOAR).

https://docs.sunpy.org/projects/soar/

BSD 2-Clause "Simplified" License

17 stars 10 forks source link

Closed hayesla closed 11 months ago

hayesla commented 11 months ago

Fixes #93

codecov-commenter commented 11 months ago

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
sunpy_soar/attrs.py	`100.00%`
sunpy_soar/tests/test_sunpy_soar.py	`100.00%`

:loudspeaker: Thoughts on this report? Let us know!.

wtbarnes commented 11 months ago

Can we call .lower on all input product names such that the case that the user specifies the product name in does not matter?

nabobalis commented 11 months ago

Yeah, we should be able to make it case insensitive inside our attrs code so it doesn't mean a user has to change anything.

Then we can merge this and get a bugfix release out!

hayesla commented 11 months ago

yeah good idea, added in now. think this should now be good to go